Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add disjoint union of to 'disease characteristic' subclasses #8766

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add disjoint union of to 'disease characteristic' subclasses #8766

wants to merge 4 commits into from

Conversation

nicolevasilevsky
Copy link
Member

@nicolevasilevsky nicolevasilevsky commented Feb 22, 2025 •
edited
Loading

write up documentation in editors doc

added to these classes:

  • 'classic or non-classic genetic disease presentation'
  • 'congenital or acquired'
  • 'iatrogenic or non-iatrogenic'
  • 'idiopathic vs non-idiopathic'
  • 'infectious disease characteristic'
  • 'locational disease characteristic'
  • 'mosaic vs complete'
  • 'rare or common'
  • 'syndromic or isolated'

unsure if we want to add it to 'general tumor grading characteristic' as well? @cmungall?

close #8750

@nicolevasilevsky nicolevasilevsky changed the title Issue 8750 add disjoint union of to 'disease characteristic' subclasses Feb 22, 2025
@nicolevasilevsky nicolevasilevsky marked this pull request as draft February 22, 2025 23:17
@nicolevasilevsky nicolevasilevsky marked this pull request as ready for review February 22, 2025 23:28
@nicolevasilevsky
Copy link
Member Author

nicolevasilevsky commented Feb 22, 2025 •
edited
Loading

@sagehrke I recorded a video on how to add the 'disjoint union of' axiom, can you add it to YouTube? Then I will embed it in the documentation: https://drive.google.com/file/d/1g9iUUYMqrt36VVr7T0J_y1Cc96mmpLvJ/view?usp=sharing

@sabrinatoro not sure if the entities page was the best place to put this documentation, please advise if you'd like me to move it somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabrinatoro sabrinatoro Awaiting requested review from sabrinatoro sabrinatoro is a code owner

@twhetzel twhetzel Awaiting requested review from twhetzel twhetzel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add disjoint union of to disease characteristics
1 participant
@nicolevasilevsky